[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: org-attach-sync uses directory-empty-p (new in Emacs 28)

From: Maxim Nikulin
Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28)
Date: Thu, 12 Aug 2021 18:57:35 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 12/08/2021 04:17, Marco Wahl wrote:
Maxim Nikulin writes:

Compiling single /home/ubuntu/org-mode/lisp/org-compat.el...

In end of data:
org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not
known to
     be defined.

How make the compiler happy?

I have never fought with this kind of problem. After looking at the other constructs in the org-compat.el file, I have tried

(if (fboundp 'directory-empty-p)
    (defalias 'org-directory-empty-p #'directory-empty-p)
  (defun org-directory-empty-p (dir)
    ; ...

I have no idea if there are any drawbacks of such approach, I can only say that such form suppresses the warning.

It seems, version comparison is sensible when an existing function gets new arguments, not in the case of completely new function.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]