Re: [BUG] org-capture autoload bug? [9.5.2 (9.5.2-gfbff08 @ /home/ignacio/.emacs.d/elpa/org-9.5.2/)]

[Max Nikulin]

On 12/03/2022 02:59, Tim Cross wrote:
> Ignacio Casso writes:

> >    (let ((org-capture-templates
> >           '(("d" "default" entry
> >              (file+headline org-default-notes-file "Tasks")
> >              "* %?"))))
> >      (org-capture nil "d")))
> >
> > I put an autoload cookie myself and it doesn't fix it, so it's probably
> > not that. It's the first time I manage autoload cookies though, so I may
> > have done something wrong. I only tested that the autoload cookie worked
> > by checking that before loading org-capture, org-capture-templates
> > appears in the completion list for C-h v, and I can evaluate it.
>
> While I don't know if this is a bug, it certainly doesn't seem to be
> doing the right thing from an 'intuitive' point of view. I would expect
> when a variable is bound to a value inside a let and a function is then
> called which uses that variable, the initial let bound value should be
> used and the result be the same regardless of whether org-capture has or
> has not been loaded. It means there is a hidden side-effect here, which
> isn't good and probably needs more analysis. If you had set the value
> using setq rather than as a let form, it wouldn't be overridden when
> org-capture is loaded, so why does it when it is a let binding?

For `defcustom' autoload generates no more than

    (defvar org-capture-templates nil "...")

It seems, behavior depends on whether `org-capture-templates' has the 
:set attribute. The setter receives nil instead of the let-bound value. 
I can not say I understand the tricks with bypassing lexical binding in 
`defcustom' and some checks in `custom-declare-variable'. Since emacs-26 
something has changed:

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6309131349
> -  ;; Use defvar to set the docstring as well as the special-variable-p flag.
> -  ;; FIXME: We should reproduce more of `defvar's behavior, such as the warning
> -  ;; when the var is currently let-bound.
> -  (if (not (default-boundp symbol))

I am unsure that the setter of `defcustom' should get let-bound value in 
the case of autoloading since it might lead to fragile behavior.

I still think that explicit templates argument for `org-capture' is 
better than relying on autoloading.

Reading the code I noticed `org-capture-templates-contexts' so I wonder 
if it might help for the original use case.