[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full

From: Bhavin Gandhi
Subject: Re: [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full frame" and missing log note
Date: Thu, 14 Jul 2022 20:52:04 +0530

On Mon, 11 Jul 2022 at 07:26, Ihor Radchenko <yantar92@gmail.com> wrote:
> Bhavin Gandhi <bhavin7392@gmail.com> writes:
> >> A better fix may relate to the fact that org-add-log-setup is usually
> >> used to run org-add-log-note at the end of current command. y-or-n-p or
> >> any other kind of command (e.g. added via advice) will break this
> >> assumption we use. So, org-add-log-setup could also store
> >> `this-command', say, in `org-log-note-this-command' and
> >> `org-add-log-note' can then execute only when `this-command' is the same
> >> with `org-log-note-this-command'. WDYT?
> >
> > I had something similar in my mind, something like we check if
> > this-command is org-* (not very robust). Your idea makes sense to
> > me. But this won't work when read-from-minibuffer is called as it
> > doesn't seem to change this-command when it runs.
> Then, we will also need to save (recursion-depth) value and check for it
> in addition to this-command.

Thanks for the idea, I'm exploring (recursion-depth),
(minibuffer-depth). I will come up with a patch to fix this bug.

Seems like soon I will cross the TINYCHANGE limit, so I will get the
FSF copyright assignment done.

Bhavin Gandhi (bhavin192) | https://geeksocket.in

reply via email to

[Prev in Thread] Current Thread [Next in Thread]