[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5] ol.el: add description format parameter to org-link-param

From: Ihor Radchenko
Subject: Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters
Date: Sat, 16 Jul 2022 17:09:45 +0800

Hugo Heagren <hugo@heagren.com> writes:

>> Currently, the internal implementation will treat nil return value as if
>> there was no :default-description and org-link-make-description-function
>> were set to nil. We may probably document this. It sounds like a useful
>> behavior.
> I added some relevant documentation to the `:default-description' part
> of the `org-link-parameters' docstring. I also changed the
> previosly-failing test to expect the right value. All the tests pass
> now.

Thanks! Can you also update the documentation for

> From cd5268bc05324140a4cf384ce12b99bba1ddab47 Mon Sep 17 00:00:00 2001
> From: Hugo Heagren <hugo@heagren.com>
> Date: Mon, 28 Mar 2022 23:18:45 +0100
> Subject: [PATCH] ol.el: add description format parameter to
>  org-link-parameters

Also, can you please review the comments from Max:

> +    ;; Copy all keys in `parameters' and their original values to
> +    ;; `orig-parameters'.
> +    (cl-loop for param in parameters by 'cddr
> +             do (setq orig-parameters
> +                      (plist-put orig-parameters param 
> (org-link-get-parameter type param))))

Thinking about this part a bit more, I have realized that even better
option would be using map-do.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]