[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7] ol.el: add description format parameter to org-link-param

From: Max Nikulin
Subject: Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters
Date: Sun, 24 Jul 2022 17:34:29 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 23/07/2022 20:06, Ihor Radchenko wrote:
Max Nikulin writes:

If it still fails, could you try isolating whether it's a specific
`should' clause which is the problem, if it fails with any of them?

It is `map-do' that causes the problem. Maybe earlier implementation in
Emacs-26 has some peculiarities. It is the version available from the
system repository for Ubuntu-20.04 LTS focal.

Tests do not fail on my side using Emacs 26.3

Ihor, what is the origin of your Emacs-26.3? The patch uses `map-do' with plist argument. I have tried:

---- >8 ----
(require 'map)
(map-do (lambda (k v) (message "alist map-do: %S: %S" k v)) '((1 . 'a)))
(setq pl nil)
(setq pl (plist-put pl :a 'a))
(message "plist: %S" pl)
(map-do (lambda (k v) (message "plist map-do %S: %S" k v)) pl)
---- 8< ----

Emacs-26.3: failure
emacs -Q --batch -l test-map-do.el
alist map-do: 1: (quote a)
plist: (:a a)
Wrong type argument: listp, :a

Emacs-27: works
emacs -Q --batch -l test-map-do.el
alist map-do: 1: 'a
plist: (:a a)
plist map-do :a: a

It is consistent with
f68f2eb472 2018-12-20 08:40:43 -0500 Stefan Monnier: * lisp/emacs-lisp/map.el: Add support for plists

I see no equivalent change in emacs-26 branch and emacs-26.3 tag.

So I am puzzled how tests using a macro with map-do and plist may pass under Emacs-26.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]