[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [calendar] Holidays menu doesn't go away

From: Stefan Monnier
Subject: Re: [calendar] Holidays menu doesn't go away
Date: Sat, 22 Mar 2003 16:39:09 -0500

> >> The "Holidays" menu doesn't go away after quitting from the calendar.
> > There is a similar symptom if you invoke then quit `info'.
> Getting rid of the (push 'menu-bar path) avoids those problems, but
> causes `recentf-mode' not to add its menu.  This reversion avoids
> that too.  But I don't why the change was made.
> diff -u -r1.57 easymenu.el
> --- easymenu.el       16 Mar 2003 00:39:23 -0000      1.57
> +++ easymenu.el       20 Mar 2003 02:24:01 -0000
> @@ -516,9 +516,6 @@
>  ITEM is either defined as in `easy-menu-define' or a non-nil value returned
>  by `easy-menu-item-present-p' or `easy-menu-remove-item' or a menu defined
>  earlier by `easy-menu-define' or `easy-menu-create-menu'."
> -  (unless map
> -    (setq map (current-global-map))
> -    (push 'menu-bar path))

The logentry explains why:

        * emacs-lisp/easymenu.el (easy-menu-name-match): Catch any error
        that member-ignore-case might signal.
        (easy-menu-add-item): Default to the global map, as documented.
        (easy-menu-convert-item-1): Use match-string.

As for where it's documented: in the docstring a few lines above.
So recentf should probably not use a nil MAP if it wants to use
the local map.
Or should we change the doc instead ?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]