Re: (that binding is currently shadowed ...)

[Stefan Monnier]

>> If cua-mode is enabled and you define a minor mode using C-c as a
>> prefix key you describe-bindings wrongly says that C-c is
>> shadowed. This is quite disturbing since C-c by some of the
>> punctuation characters is what a minor mode is supposed to use (my
>> example uses C-c RET which is a bit bad). Here is how the output can
>> look:
>> 
>> key             binding
>> ---             -------
>> 
>> C-c          Prefix Command
>> (that binding is currently shadowed by another mode)
>> 

> Here is a patch which fixes this problem.  I'm not sure whether it
> has any bad effects in other cases.  Stefan?

I'm not very familiar with this code, actually.
But it doesn't look quite right.  I believe the test

   !(KEYMAPP (definition) && KEYMAPP (tem))

should be done outside the other `if', so that it also prevents using
`continue' if mention_shadow is 0.  OTOH in the case of EQ (tem, definition)
we still want to continue unconditionally.

Also, I'm not quite sure how this code handles the recursion in sub-keymaps,
so maybe I'm talking nonesense.


        Stefan


PS: The "*/" on a separate line is not the style used in Emacs's C code
    usually, so I'd rather not introduce it here.