[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] Re: [Emms-patches] darcs patch: emms-i18n changes, add playl

From: Jorgen Schaefer
Subject: [emms-help] Re: [Emms-patches] darcs patch: emms-i18n changes, add playlist navigate command, uniq...
Date: Thu, 07 Dec 2006 10:48:17 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.90 (gnu/linux)

Ye Wenbin <address@hidden> writes:

> +(defun emms-uniq-list (list stringfy)
> +  "Compare stringfied element of list, and remove duplicate elements."
> +  (let ((hash (make-hash-table :test 'equal))
> +        str)
> +    (remove-if (lambda (elm)
> +                 (setq str (funcall stringfy elm))
> +                 (if (gethash str hash) t
> +                   (puthash str t hash) nil)) list)))

emms.el currently does not use or require 'cl. I'd actually be
rather happy if it could stay that way. I fixed the code to live
without cl.

Also, please be careful when writing lisp code. Lines of code is
not something you have to optimize for. Multiple statements per
line are easily overlooked.

One additional note: Please try to separate semantically disjunct
changes into different darcs patches. Thanks :-)

        -- Jorgen

((email . "address@hidden") (www . "http://www.forcix.cx/";)
 (gpg   . "1024D/028AF63C")   (irc . "nick forcer on IRCnet"))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]