[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [emms-help] BUG: emms-show-all-mode zaps window configuration on qui

From: Yoni Rabkin
Subject: Re: [emms-help] BUG: emms-show-all-mode zaps window configuration on quit
Date: Wed, 13 Jun 2018 23:46:02 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Fran Burstall <address@hidden> writes:

> I have two windows open and do M-x emms-show-all.  One
> window is filled with track info.  Now I hit 'q' to call
> emms-show-all-mode-bury-buffer.
> What I expect: the emms-show-all buffer to disappear and its
> window to display whatever it displayed before I did M-x
> emms-show-all.
> What happens: the buffer and the window it was in both
> disappear so I now only have one window.
> Not passing the buffer name to bury-buffer (which will then
> remove the buffer from the window) and not calling
> delete-window fix this (at least to me) undesirable
> behaviour.
> Thus:
> (defun emms-show-all-mode-bury-buffer ()
>   "Bury, and optionally kill the show buffer."
>   (interactive)
>   (bury-buffer)
>   ;; (delete-window)
>   (when emms-show-all-kill-buffer-on-quit-p
>     (kill-buffer emms-show-all-buffer-name)))

I've fixed this with `quit-restore-window' and pushed to the git
repo. Can you please test it?

Thanks for the bug report.

   "Cut your own wood and it will warm you twice"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]