Re: emms-player-mpv-update-metadata

[Yoni Rabkin]

Mike Kazantsev <mk.fraggod@gmail.com> writes:

> On Sat, 24 Jul 2021 08:15:52 -0400
> Yoni Rabkin <yoni@rabkins.net> wrote:
>
>> Can you provide guidance for using `emms-player-mpv-update-metadata' to
>> get icy tags from streams? If you provide some code samples I can use
>> those to flesh out a new section in the manual.
>
> It's obviously just a boolean customize-setting, defined as
>
>   (defcustom emms-player-mpv-update-metadata nil
>     "Update track info (artist, album, name, etc) from mpv events, when it is 
> played.
>   This allows to dynamically update stream info from ICY tags, for example.
>   Uses `emms-player-mpv-event-connect-hook' and 
> `emms-player-mpv-event-functions' hooks."
>     :type 'boolean
>     ...
>
> Which is supposed to be customizable interactively via the usual
> "customize" or "customize-group emms-player-mpv" interactive commands.
>
> I set it via:
>   (custom-set-variables '(emms-player-mpv-update-metadata t t))
>
> And it should obey all the usual rules wrt customizable vars in emacs.

I'll add that under the "Streaming Audio" section of the manual. Thanks.

> But trying interactive customize just now myself, found that
> "emms-player-mpv" group might be missing (defgroup ...) definition
> and signals error on rendering its two values with :set handler.
>
> Not sure why latter happens - pretty sure it used to work, 
> will need to look into it a bit later.
> Might be related to lexical binding change or changes in emacs.

Other players get their customize menu via the
`define-emms-simple-player' macro. Nothing good comes of `customize'
(one of my least favorite Emacs features), but I guess we need to fix
it.

-- 
   "Cut your own wood and it will warm you twice"