[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fluid-dev] [PATCH] Effect level clip

From: Josh Green
Subject: Re: [fluid-dev] [PATCH] Effect level clip
Date: Mon, 17 Sep 2007 13:09:07 -0700

On Mon, 2007-09-17 at 21:06 +0100, Rui Nuno Capela wrote:
> this is in fact one of my proposed patches (attached once again).
> without this one qsynth reverb level is stuck to 100%, surely everyone
> has this for granted ;)
> i remember it was argued by Peter himself during 1.0.4 release iirc;
> never quite understood his point and still unconvinced ever since.
> all my personal fluidsynth builds include this simple patch and am 100%
> confident it does not harm to regress.
> cheers

Hey Rui!

I completely forgot about your contribution concerning this issue, sorry
about that.  That would make the fluid_revmodel_getlevel() function
revert to its previous incarnation of:

return rev->wet / scalewet;

Probably could even remove the rev->level field at that point.  This
seems like the right way to do things.  Anyone got any objections or
comments on this?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]