[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fluid-dev] [PATCH] Effect level clip

From: David Hilvert
Subject: Re: [fluid-dev] [PATCH] Effect level clip
Date: Mon, 17 Sep 2007 17:42:59 -0500

On Mon, 17 Sep 2007 13:09:07 -0700
Josh Green <address@hidden> wrote:

> return rev->wet / scalewet;
> Probably could even remove the rev->level field at that point.  This
> seems like the right way to do things.  Anyone got any objections or
> comments on this?

If the 'wet' code is uncommented, and the effect level clip patch is reverted,
does the gain control work as expected?  If so, the benefit of the effect level
clip patch is unclear; if not, the benefit of the commented code is unclear.

If the goal is solely to keep one of level and wet as an effect gain control,
the answer should probably depend on which one works better for this.  OTOH,
it's possible that wet is doing something else useful; could it be renamed?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]