[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[fluid-dev] Removing g_shell_parse_argv

From: Ryan Gonzalez
Subject: [fluid-dev] Removing g_shell_parse_argv
Date: Sun, 3 Jul 2016 14:52:42 -0500

Good news: I'm almost done with removing glib!
Bad news: I'm not done yet!

Last things to remove are g_shell_parse_argv (in fluid_command) and g_strfreev (used to free the result of g_shell_parse_argv). Both are used in fluid_command. I pulled up `git log` and found:

commit fa73a202af58512b2b5b6f80f6feb8c3c5271575
Author: David Henningsson <address@hidden>
Date:   Sun Mar 27 17:37:44 2011 +0000

    Use glib utility function for shell parsing - fixes ticket #44

And I found the ticket: https://sourceforge.net/p/fluidsynth/tickets/44/

My question: how exactly should this be implemented? glib's implementation seems quite complex (~700 LOC with comments and blank lines). I wouldn't be against just adding in gshell.c directly and modifying it to not require glib...

[ERROR]: Your autotools build scripts are 200 lines longer than your program. Something’s wrong.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]