[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fluid-dev] Using absolute generator values

From: Marcus Weseloh
Subject: Re: [fluid-dev] Using absolute generator values
Date: Thu, 7 Dec 2017 11:17:59 +0100


I also can't see how this function could ever have had any effect. So really, by changing the code so that it does have an effect, you are introducing a new feature. Looking through the mailing-list archives of the last 14 years, there are only four posts that mention the fluid_synth_set_gen2 function.

One person stumbled across it and wondered why it doesn't have an effect. The others came from the thread-safety changes when somebody found the function in the code and decided to make it part of the public API, because: "These functions were meant to be made public at some point, as the comment suggests at the top of fluid_synth.c".

So it seems to me like no user has ever requested or used that feature, at least not in the last 14 years. And it's not part of the SoundFont specs. I would vote to simply remove it.



2017-12-06 12:12 GMT+01:00 Tom M. <address@hidden>:
While cleaning up the code base I stumbled over a feature provided by
fluid_synth_set_gen2() which is to set generators to an absolute
value. Introduced 14 years ago, this feature never seemed to have
worked, but still I would like to know if there is anybody using
fluid_synth_set_gen2() at all or if anyone has a use-case for using
absolute generator values?


fluid-dev mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]