freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] FT_MulDiv optimization


From: Werner LEMBERG
Subject: Re: [ft-devel] FT_MulDiv optimization
Date: Sat, 05 Jul 2014 08:05:19 +0200 (CEST)

>> >> a + b < 92681 - (c >> 16) + ((c+ 235935) >> 18)
>> >
>> > How about the simpler:
>> >
>> > a + b <= 92681 - (c >> 16)
>>
>> I like this!
> 
> Pushed.

Thanks a lot!  However, please expand the comment, since the involved
mathematics is not trivial.  For example, it is non-obvious to have a
multiplication

  (a * b + c/2) / c

but the condition only contains an addition.  IMHO there is one step
missing in the explanation chain.  Similarly, I ask you to add the
formula for the Taylor expansion.

And you should add your name there, too :-)


    Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]