freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] [freetype2] GSoC-2019-moazin 8887048: Performs basic to s


From: Werner LEMBERG
Subject: Re: [ft-devel] [freetype2] GSoC-2019-moazin 8887048: Performs basic to see if SVG data is valid or not.
Date: Tue, 30 Jul 2019 06:15:29 +0200 (CEST)

> Well one thing that just came to my mind is that though these checks
> aren't problematic, I am not sure how useful they are from a
> practical point of view.  If somebody had to get invalid tables
> passed in, there can be many ways to do that and its impossible and
> also pointless to check for all of them on FT side.  So yea, maybe I
> should reconsider these.

Behdad is right.  Don't test stuff that FreeType doesn't need for
itself.  In other words, only test data that FreeType itself is going
to access.  For example, if we need the 12th byte of structure `foo',
then we should check whether we can do that, together with some sanity
tests to find out whether this value in `foo' is reasonable.


    Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]