Re: [glob2-devel] Another speedup (computeColors)

[Kieran P]

Wow. You seem really active with development. Thats great. Keep up the awesome work!!

On a side note, no one here seems to be committing what you submit :P Probably because everyone is busy.

It might be better if you request Mercurial access from Nct, send us an email when you have it, and one of us who knows how can tell you how to use it (cloning, branching, and committing).

That way, you can make these changes, check it compiles, and if it works, submit right away (no diff files needed).

The game really needed these speed increases, so thank you for them.

Regards
Kieran

On 9/7/07, Erik Søe Sørensen <address@hidden> wrote:

Hi again,
I said I'd look at algorithmic improvements to the gradient updating
operations... well, I did, but I chose the wrong starting point. I've
got some ideas to try out (most of which concern avoiding to update all
of the map), but that'll wait a bit.

For now, I've got some other spectacular result for ya :-D - a twofold
increase in the speed of Minimap::computeColors() (on my box at least) :-)

I tried several different things, but what turned out to be the real
problem was the use of floats (and perhaps especially the
float-to-integer conversion which was done for each relevant map square).

So the attached patch just replaces this with fixed-point computations,
and then moves some variable declarations to their 'proper' places
(because that's nicer, for programmers and compilers alike :-).

/Erik
PS: Have you considered adding a '-Wall' switch or similar to the
compiler invocation?
(Not that I've noticed anything horrible - it's just good practise afaik)

_______________________________________________
glob2-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/glob2-devel

-- 
Kieran.P
http://qlwiki.linuxsolutions.co.nz/