Re: [Gnash-commit] gnash ChangeLog libamf/amf.cpp server/vm/Action...

[Rob Savoye]

Sandro Santilli wrote:
> On Sat, May 17, 2008 at 08:10:40PM +0000, Sandro Santilli wrote:
>
> > http://cvs.savannah.gnu.org/viewcvs/gnash/libamf/amf.cpp?cvsroot=gnash&r1=1.79&r2=1.80
>
> Oops, didn't mean to commit this.
>
> Fixes mismatching free/delete (bug #) but rob mentioned he's going to fix
> in another way.
>
> I can revert the patch if it makes conflicts resolution too much of a pain.
> Let me know.

  No "problems", but please revert this patch, as it only gets rid of a 
warning due to a bug in valgrind, not amf.cpp. As i said in irc, I don't 
want to use a std::string, I'd rather typecast tmpptr, which is an NON 
NULL terminated string. Originally tmpptr was typecast, but that got 
other stupid valgrind warnings that were totally bogus.

  I plan to drop the debug messages soon anyway, at which point this 
code won't even exist anymore.

        - rob -