[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog libamf/amf.cpp server/vm/Action...

From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog libamf/amf.cpp server/vm/Action...
Date: Sun, 18 May 2008 19:30:31 +0200

On Sun, May 18, 2008 at 06:23:38PM +0200, Rob Savoye wrote:
> strk wrote:
> >But really is just an optimization, as long as you're modifying
> >that code anyway what is it worth ?
>   My point exactly. :-) it's a temporary debug message, and I've stated 
> several times it'll get fixed while I continue working on the AMF code 
> as I create the client side of RTMP for Gnash. But if you want to fix 
> the valgrind warning, then type cast tmpptr to name, rather than 
> creating a std::string. As the ASCII string of the property name is in 
> tmpptr, allocating a string is a performance hit. ()although a small one)

Typecasting would have forced me to drop debugging messages (ASCII string
is not null-terminated), and I didn't want to change semantic of the code.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]