[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] /srv/bzr/gnash/trunk r9668: Plug leak.

From: Bastiaan Jacques
Subject: Re: [Gnash-commit] /srv/bzr/gnash/trunk r9668: Plug leak.
Date: Fri, 5 Sep 2008 06:26:40 -0700 (PDT)
User-agent: Alpine 1.00 (DEB 882 2007-12-20)

On Fri, 5 Sep 2008, Benjamin Wolsey wrote:

Where would you put it? I'm not that keen on utility.h, but it seems
like the most appropriate place for it. It would be used at least in
PlaceObject2Tag.cpp and sound_handler_sdl.cpp, so libcore and libmedia.
Alternatively, we could start a new header file in libbase for really
useful common code and leave the compatibility hacks to utility.h.

I don't like general utility header files, because eventually they all
end up looking like gnash.h, which will then bloat the compilation

I prefer to have a file specific for a single purpose or a collection of
related purposes. In this case, I'd like to create a file specifically
for utility templates for containers. So something like

It does work with boost 1.33, doesn't it? I know boost.Range is in that
version, but I haven't tested this code specifically.

It works with 1.34. I should probably install 1.33 anyway, so I can test
these things before committing.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]