[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [bug #46115] Gnash doesn't always terminate lines when se
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [bug #46115] Gnash doesn't always terminate lines when sending message to host container |
Date: |
Sat, 03 Oct 2015 17:03:45 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0 |
URL:
<http://savannah.gnu.org/bugs/?46115>
Summary: Gnash doesn't always terminate lines when sending
message to host container
Project: Gnash - The GNU Flash player
Submitted by: nachanon
Submitted on: Sun 04 Oct 2015 12:03:44 AM ICT
Category: core
Severity: 3 - Normal
Release: master
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
This is a spin-off from bug #37223 (ExternalInterface callback issue).
It it kind of a cosmetic issue, but affects on how automated tests could be
written.
Current version of Gnash uses an inconsistent line separation when sending
message to host container (like libgnashplugin), for example:
* Flash 8 ExternalInterface:
** AddMethod command issued from `ExternalInterface.addCallback()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1866>
via `ExternalInterface::makeInvoke()` have newline
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/ExternalInterface.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n320>.
** Return value from ExternalInterface callback *does not* have newline
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1959>.
** Invoke command issued from `ExternalInterface.call()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1898>
via `ExternalInterface::makeInvoke()` have newline.
* GetVariable() plugin function:
** Return value from `GetVariable()` call *does not* have newline
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1605>.
* Other browser function:
** Invoke command issued from `getURL()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n2265>
via ExternalInterface::makeInvoke() have newline.
** Invoke command issued from `fscommand()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/Player.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n714>
have newline.
You may see that all command issued through `ExternalInterface::makeInvoke()`
have newline, but return values (which didn't use `makeInvoke()`)
do not have it.
These inconsistency does not affect NPAPI libgnashplugin.
But if fixed, it will make a devlopment of container emulation-based
<https://savannah.gnu.org/bugs/?37223#comment7>
automated test easier as the conversation could be read by line boundary.
(Currently, test runner would need to employ an XML-like parser)
Gnash: 0.8.11dev (git f0f66ce 23-Sep-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?46115>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Gnash-commit] [bug #46115] Gnash doesn't always terminate lines when sending message to host container,
Nutchanon Wetchasit <=