[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #8758] Patch to add newlines to Gnash player-to-pl
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [patch #8758] Patch to add newlines to Gnash player-to-plugin return value messages |
Date: |
Mon, 05 Oct 2015 07:12:50 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0 |
URL:
<http://savannah.gnu.org/patch/?8758>
Summary: Patch to add newlines to Gnash player-to-plugin
return value messages
Project: Gnash - The GNU Flash player
Submitted by: nachanon
Submitted on: Mon 05 Oct 2015 02:12:49 PM ICT
Category: core
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
Currently, Gnash does not always terminate message sent to host container via
`-F`/`--fd` pipe with '\n', which can causes difficulty in writing a
line-based
container-emulation automated test
<https://savannah.gnu.org/bugs/?37223#comment17>.
The patch adds newline to every return value-related message that Gnash
sends to host container:
* Return value from ExternalInterface callback
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1959>
* Return value from GetVariable() plugin function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1605>
* Return value from IsPlaying() plugin function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1617>
* Return value from PercentLoaded() plugin function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1641>
* Return value from TotalFrames() plugin function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n1671>
which fixes bug #46115.
This should not have any affect on NPAPI libgnashplugin's normal operation.
Note: It might need a bit of review, since there're two way to implement
this,
one is using `std::endl` with `std::stringstream` (which is used by
`ExternalInterface.makeInvoke()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/ExternalInterface.cpp?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n320>),
another way is using bare '\n'.
The patch uses the former.
Gnash: Gnash 0.8.11dev (patched against git f0f66ce 23-Sep-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Mon 05 Oct 2015 02:12:49 PM ICT Name:
0001_add-newline-externalinterface-pluginfunc-return.patch Size: 3kB By:
nachanon
Patch to add newlines to Gnash player-to-plugin return value messages
<http://savannah.gnu.org/patch/download.php?file_id=35065>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8758>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Gnash-commit] [patch #8758] Patch to add newlines to Gnash player-to-plugin return value messages,
Nutchanon Wetchasit <=