[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #8933] Patch to use `_global` as a fallback `this`
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [patch #8933] Patch to use `_global` as a fallback `this` object in ExternalInterface callback |
Date: |
Wed, 09 Mar 2016 06:09:44 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1 |
Follow-up Comment #3, patch #8933 (project gnash):
Patch 2 of 2:
See the attached
`0008_add-external-interface-global-instance-fallback-prop-assignment-test.patch`.
This patch adds few more checks on relationship of `this` pointer inside
ExternalInterface callback registered with `null`/`undefined` context
and the `_global` object; by trying to assign a string member to it.
If the member could be accessed later via `_global` object: PASS, otherwise:
FAIL.
(It is the same check as ones provided in `js2flash-nothis-v2.html` test
<https://savannah.gnu.org/bugs/?37223#comment24>)
Might need a review, since I'm not sure if this kind of property assignment
checks are redundant or not, as the previously-added strict equality test
should already check that `this` and `_global` are the same object instance
(provided that the operator works correctly on Gnash).
(file #36574)
_______________________________________________________
Additional Item Attachment:
File name:
0008_add-external-interface-global-instance-fallback-prop-assignment-test.patch
Size:3 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8933>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/