[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #8938] Patch to add a missing bracket in front of
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [patch #8938] Patch to add a missing bracket in front of debug log messages |
Date: |
Wed, 09 Mar 2016 10:42:48 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1 |
URL:
<http://savannah.gnu.org/patch/?8938>
Summary: Patch to add a missing bracket in front of debug log
messages
Project: Gnash - The GNU Flash player
Submitted by: nachanon
Submitted on: Wed 09 Mar 2016 05:42:47 PM ICT
Category: None
Priority: 4
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
This is kind of a cosmetic issue, and is trivial to fix.
When I looked at current Gnash's debug output, e.g.:
20044:1] 678 TRACE: Hello World!
It bugs me a lot that what exactly first two number, colon, and
a _dangling bracket_ printed in front of log message are for [1].
It first glance, I thought it was some kind of broken ANSI escape code.
After I digged around Gnash's libbase code, I found that the numbers are
actually process ID and thread ID, which makes sense; but the open bracket
was
conspicuously missing
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libbase/log.cpp?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n105>.
So I wrote a patch to fix the missing bracket, see the attached
`0001_add-missing-bracket-to-debug-log.patch`.
After applied the patch, you'll see that Gnash's debug output now look like:
[3916:1] 131 TRACE: Hello World!
Gnash: 0.8.11dev (patched against git 8b33692 7-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386
[1] Side note: I have searched around current Gnash user manual and developer
reference, and found nothing that mention process/thread ID part of the log
message. (For the timestamp, developer reference only briefly mentioned it as
a part of `LogFile::setStamp()` description
<http://git.savannah.gnu.org/cgit/gnash.git/tree/doc/C/refmanual/logging.xml?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n233>)
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Wed 09 Mar 2016 05:42:47 PM ICT Name:
0001_add-missing-bracket-to-debug-log.patch Size: 532B By: nachanon
Patch for adding the missing open bracket to log messages
<http://savannah.gnu.org/patch/download.php?file_id=36577>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8938>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Gnash-commit] [patch #8938] Patch to add a missing bracket in front of debug log messages,
Nutchanon Wetchasit <=