[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Improve URL parsing using a sane comparison. (patch)

From: Bastiaan Jacques
Subject: Re: [Gnash-dev] Improve URL parsing using a sane comparison. (patch)
Date: Mon, 17 Jul 2006 02:40:39 +0200
User-agent: KMail/1.9.3

On Sunday 16 July 2006 09:53, annonygmouse wrote:
> I've found lots of URLs that the plugin didn't know how to parse
> "Can't parse URL".

Could you provide an example of a URL that would fail to be parsed?

> The problem is a unsane comparison.

Why is the comparison insane? I will agree that the check should really 
be if (end == string::npos), but it does work as is.

> I attach a patch that works for me.

I don't see how your patch changes anything, because `end' is declared 
size_t, which, on my platform, is defined as int. So, in my view, 
you're casting an int to an int.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]