Re: [Gnewsense-dev] Partial patch to gen-kernel

[Karl Goetz]

On Thu, 13 Aug 2009 23:08:46 +0200
Sam Geeraerts <address@hidden> wrote:

> Karl Goetz schreef:
> > The code to modify the b43 related bug is commented out. I got help
> > writing the sed line, and I have NFI what it does. I'm not putting
> > it in without understanding.
> 
> Sed FAQ [1] 4.13 sheds some light on that. In pseudocode:

(code)

> Or in plain words: get 3 consecutive lines, check if it's the string
> you want to replace and replace if it is.

I think I prefer the plain words to sed speak ;)

> But the patch as it is now (if uncommented) won't work. First of all,
> it doesn't provide input for sed. This will make it wait for input.
> You probably want:
> 
>   sed -i '/CONFIG_VIDEO_CX23885/d' ./drivers/media/video/Makefile
> +
> +# Stop b43 ...
> +sed -i ':more...' ./drivers/net/wireless/b43/main.c
> +

Yes, well caught. So far I've only really worried about the aty* code -
I'll add the file path in now.

> Secondly, the search string as it is now doesn't take the whitespace
> in the code into account. I think that it should be something like:
> 
> s|.*b43err...to "\n.*"http...firmware "\n.*and..\\n");|See...|;

Are you able to help test that theory?
kk

> [1] http://www.faqs.org/faqs/editor-faq/sed/


-- 
Karl Goetz, (Kamping_Kaiser / VK5FOSS)
Debian contributor / gNewSense Maintainer
http://www.kgoetz.id.au
No, I won't join your social networking group

signature.asc
Description: PGP signature