Re: [Gnu-arch-users] 'tla changes' queries the archive

[Aaron Bentley]

Mikhael Goikhman wrote:
> I upgraded from tla 1.2 to 1.2.2rc2 and see this unencouraging behaviour.
>
> In 1.1 and 1.2, 'changes' verifies the local files and returns shortly.
> In 1.2.2rc2, 'changes' retrieves multiple files from the archive that
> makes this command very slow. Tried with several trees and archives.

It's caused by the new user-input validation code.  changes is making 
sure the requested revision exists, by consulting the source.  I've got 
a patch here:
address@hidden/tlasrc--devel--0.2--patch-10

That will check the revlib first, and only check the archive if it's not 
in the revlib.  But for 'changes', it looks like the input validation is 
in the wrong place; it shouldn't be validating information it gets from 
log files, just user input.

Aaron

--
Aaron Bentley
Director of Technology
Panometrics, Inc.