[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] 'tla changes' queries the archive

From: Mikhael Goikhman
Subject: Re: [Gnu-arch-users] 'tla changes' queries the archive
Date: Fri, 17 Sep 2004 01:57:50 +0000
User-agent: Mutt/

On 13 Sep 2004 17:28:26 -0400, Aaron Bentley wrote:
> Mikhael Goikhman wrote:
> >I upgraded from tla 1.2 to 1.2.2rc2 and see this unencouraging behaviour.
> >
> >In 1.1 and 1.2, 'changes' verifies the local files and returns shortly.
> >In 1.2.2rc2, 'changes' retrieves multiple files from the archive that
> >makes this command very slow. Tried with several trees and archives.
> It's caused by the new user-input validation code.  changes is making 
> sure the requested revision exists, by consulting the source.  I've got 
> a patch here:
> address@hidden/tlasrc--devel--0.2--patch-10

I hope this patch will be in 1.2.2rc3. But it is not quite the solution.

> That will check the revlib first, and only check the archive if it's not 
> in the revlib.  But for 'changes', it looks like the input validation is 
> in the wrong place; it shouldn't be validating information it gets from 
> log files, just user input.

Any plans about this? I think this is clearly a bug and should be fixed
before the final 1.2.2. 'tla changes' (without any revision argument) is
probably the most used command. Can you please fix it, Aaron?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]