[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [GNUnet-developers] GSoC: Binary package distribution through GnuNet
Re: [GNUnet-developers] GSoC: Binary package distribution through GnuNet (report 2)
Thu, 25 Jun 2015 22:15:31 +0200
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
(+ Cc: gnunet-developers.)
I’m happy to report that examples/search.scm works for me as advertised.
I was even able to find a copy of the GPL and gnunet-c-tutorial.pdf.
The tests pass, except for progress-info.scm:
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=0
;;; or pass the --no-auto-compile argument to disable.
;;; compiling /data/src/guix-gnunet/./run-tests.scm
;;; compiling /data/src/guix-gnunet/tests/binding-utils.scm
%%%% Starting test test-binding-utils (Writing full log to
# of expected passes 7
;;; compiling /data/src/guix-gnunet/tests/configuration.scm
%%%% Starting test test-configuration (Writing full log to
# of expected passes 9
;;; compiling /data/src/guix-gnunet/tests/container-metadata.scm
%%%% Starting test test-container-metadata (Writing full log to
# of expected passes 12
;;; compiling /data/src/guix-gnunet/tests/progress-info.scm
;;; WARNING: compilation of /data/src/guix-gnunet/tests/progress-info.scm
;;; ERROR: Syntax error:
;;; /data/src/guix-gnunet/tests/progress-info.scm:41:0: source expression
failed to match any pattern in form (%test-error (quote invalid-arg)
%%%% Starting test test-fs-progress-info (Writing full log to
ice-9/psyntax.scm:1422:32: In procedure expand-macro:
ice-9/psyntax.scm:1422:32: Syntax error:
/data/src/guix-gnunet/tests/progress-info.scm:41:0: source expression failed to
match any pattern in form (%test-error (quote invalid-arg)
Some deprecated features have been used. Set the environment
variable GUILE_WARN_DEPRECATED to "detailed" and rerun the
program to get more information. Set it to "no" to suppress
The implementation looks good to me. There are a few things that could
be made nicer with some macrology, such as the big ‘make-struct’ in
‘%gnunet-fs-start’ and the structure definitions in that file, but it’s
not necessary to spend time on this now.
Since it uses the FFI, it’s important to have good test coverage because
there’s no compiler to flag API mismatches, but that seems to be mostly
Throwing some autotools in there for good measure would be nice; as
discussed on IRC, you could simply copy and adjust configure.ac,
Makefile.am, and pre-inst-env.in from guix/dhcp.git. I’m happy to help
on that if needed.
What are your plans for the next steps now? I suppose we are targeting
the FS service, right?