[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNU Robots Patches to Contribute

From: Joshua Judson Rosen
Subject: Re: GNU Robots Patches to Contribute
Date: Mon, 8 Feb 2021 03:19:39 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0


Sorry for the ridiculously long response time on this--
a lot of stuff sort of fell apart here over the summer of 2020, and a lot of 
things that had
`next week' sort of timeframes fell through the cracks in pretty severe ways
(and unfortunately yours is one of a number of inquiries that was left hanging 
for months on end).

I've finally been able to start getting back up to speed just over the 
lastcouple of months,
and have finally resumed pushing out fixes into git that have been stuck in my 

Looking through your patch...:

... OMG--you really did have some time to work through a lot of stuff!

I love that you've added a texinfo manual and commented the API, updated to 
in addition to nearly everything else that I'd originally hoped to work on in 

Do you still have some time for this? Is there any chance that could split the 
patch up
into a series of git commits with comments summarizing what's changing and why--
and then maybe post the patch series to the list here with "git send-email"?

Actually, it would be great to have someone to help out on an ongoing basis,
if you still have the interest/availability?

On 6/22/20 7:23 PM, Matthew Henry wrote:
> Lockdown has had me spend some time on fun diversions.
> I have several patches I'd like to review with the maintainer for 
> contribution.
> Added menus to gnurobots (File/Load Map File, File/Quit, Help/About)
> Restructured the code to reduce dependencies (e.g. grobot.c used to
> bring in the entirety of GTK+, now it only depends on glib.h and
> map.h).
> Restructured GRobot and Map to emit signals on changes and modified
> the GUI code to respond to those signals.  This helps a lot in
> isolating the dependencies.
> Also I can confirm that GNU Robots does compile and run when checked
> out from Git on Fedora 31 (autoconf actually chose Guile 2.2.6, which
> is great, though I was surprised since the patch made back in the day
> targeted an earlier version of Guile).

"Don't be afraid to ask (λf.((λx.xx) (λr.f(rr))))."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]