[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Mon, 21 Jan 2008 22:39:19 +0100
Thunderbird 184.108.40.206 (X11/20070801)
thank you for that rework. I just submitted these changes to SVN, with a
slight bit of rework and reformatting.
What I don't like about the current code (not just your changes) is that
it is still unclear to me, whether the difference between the minor
releases of GLX is a compile time or run time difference. Are all the
new functions really present in a GLX version < 1.3? If not, then we
should protect these calls in the code with #ifdefs.
Also the usage of the union in pixel format looks strange, we need to
read what was set, not what suits the current GLX version. Sure this
versions wont change during the runtime of the program, still it looks
wrong. This is why I moved all of the reference to the union into the
separate file. A next step would be to clean up the usage here.
As you are now creating a separate drawable, isn't the deallocation of
that drawable needed? I put in a FIXME, where I think this call is
missing. Again it is only needed for the newer GLX release.
To me all these files look like work in progress, hopefully you keep on
working on them.
Thomas Gamper wrote:
> Recently I was using NSOpenGLView and fixed a couple of bugs in
> gnustep-back 0.12.0 ( I believe newer versions have the same issues):
> - XGGLPixelFormat handling was confusing glx parameters, since glx 1.3
> has some different parameters than earlier versions of glx
> - XGGLContext did not create the rendering context, the x window, and
> the glx window with the same Visual
> - XGGLContext did not create a colormap for the x window (which has to
> use the same Visual too)
> The attached files fix this issues. I tried to follow the gnustep
> coding style but I am not sure if I succeeded :)
> Please let me know if there are any change requests.
> I am not subscribed to the list, so please CC me.
- NSOpenGL, Thomas Gamper, 2008/01/19
- Re: NSOpenGL,
Fred Kiefer <=