[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effec

From: Eric S. Raymond
Subject: Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects
Date: Wed, 20 Jun 2012 09:17:21 -0400
User-agent: Mutt/1.5.21 (2010-09-15)

Christian Gagneraud <address@hidden>:
> A simple way to fix the problem and make everyone happy would be to
> create a gpsd_maybe_hexdump() that contains this "printable" test
> and either returns gpsd_hexdump() or the untouched buffer.
> Then the coders have the choice between a real hexdump
> (gpsd_hexdump) and a "clever" hexdump (gpsd_maybe_hexdump).

I reached the same conclusion last night, and just pushed the change.  
The "clever" version is called gpsd_packetdump().

I guess this means you can push your test changes.
                <a href="";>Eric S. Raymond</a>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]