[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] Builds made after "Fix nmea0183 v4.1 problem in processGS
|
From: |
Eric S. Raymond |
|
Subject: |
Re: [gpsd-dev] Builds made after "Fix nmea0183 v4.1 problem in processGSV()." fail the foretrex test. |
|
Date: |
Wed, 3 Jun 2015 09:59:52 -0400 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Gary E. Miller <address@hidden>:
> "Eric S. Raymond" <address@hidden> wrote:
>
> > Revert "Fix nmea0183 v4.1 problem in processGSV()."
> >
> > This change breaks regression tests ansd is uneccessary. Because
> > of the guard "if (session->fixcnt <= PPS_MIN_FIXES): in timehint.c,
> > time hints won't be shipped until fixes have been seen.
>
> Incorrect. The guard in timehint.c only prevents bad PPS time
> from being shipped to ntpd/chronyd. It does not affect serial time.
>
> Bad serial time fixes were shipped by gpsd from a bug intruducs in 2013
> until last week.
You are right. The actual problem was that I reverted your commit when
I intended to revert the following one. All fixed now.
--
<a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>
signature.asc
Description: Digital signature