[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] Builds made after "Fix nmea0183 v4.1 problem in processGS
|
From: |
Gary E. Miller |
|
Subject: |
Re: [gpsd-dev] Builds made after "Fix nmea0183 v4.1 problem in processGSV()." fail the foretrex test. |
|
Date: |
Mon, 1 Jun 2015 12:51:20 -0700 |
Yo Eric!
On Sun, 31 May 2015 10:31:19 -0400
"Eric S. Raymond" <address@hidden> wrote:
> Revert "Fix nmea0183 v4.1 problem in processGSV()."
>
> This change breaks regression tests ansd is uneccessary. Because
> of the guard "if (session->fixcnt <= PPS_MIN_FIXES): in timehint.c,
> time hints won't be shipped until fixes have been seen.
Incorrect. The guard in timehint.c only prevents bad PPS time
from being shipped to ntpd/chronyd. It does not affect serial time.
Bad serial time fixes were shipped by gpsd from a bug intruducs in 2013
until last week.
commit a9f44d1cb9db5a27832782bbe2685e66433c6d3a broke it.
commit 82d4eb4886da49807100b8b63dd138cbb1dab397 fixed it.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1(541)382-8588
pgpPue3IQBbGQ.pgp
Description: OpenPGP digital signature
- Re: [gpsd-dev] Builds made after "Fix nmea0183 v4.1 problem in processGSV()." fail the foretrex test.,
Gary E. Miller <=