grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: linux headers


From: Jeroen Dekkers
Subject: Re: linux headers
Date: Mon, 04 Jun 2007 19:35:54 +0200
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shij┼Ź) APEL/10.7 Emacs/22.0.95 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI)

At Mon, 4 Jun 2007 18:59:30 +0200,
Robert Millan wrote:
> 
> 
> How is it that util/biosdisk.c makes effort to avoid including Linux headers
> and defines Linux ioctl macros on its own?
> 
> This adds an extra maintainance burden, so I guess there must be a reason to 
> do
> it, but can't think of one..

It only defines it when it isn't defined yet. It seems to be taken
from GRUB Legacy's lib/device.c and probably comes from a time those
things weren't always defined. The checks for glibc also don't seem
that useful to me. It needs a cleanup.

Jeroen Dekkers




reply via email to

[Prev in Thread] Current Thread [Next in Thread]