[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] UUID support

From: Robert Millan
Subject: Re: [PATCH] UUID support
Date: Fri, 30 May 2008 16:07:34 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Fri, May 30, 2008 at 09:26:05PM +0800, Bean wrote:
> >
> > However, a problem with this is that it only works for i386-pc, untill we
> > define a way to store this for each variant.
> >
> > Perhaps we could instead use memdisk to store it?  Rather than put a 
> > grub.cfg
> > in memdisk, which would require builtin normal.mod, we could put a simpler
> > file (let's call it 'env') with initial environment, in the binary format
> > you describe.  Does that work?
> >
> > Then to support it in other platforms, we just need to implement memdisk in
> > them.
> We can use some function like grub_machine_get_env to return a pointer
> to the environment block, and parse it in main.c. The env block is
> string base, it can be used in any platform.

Sounds fine.

> BTW, since you have changed the filesystem structure, you need to add
> the uuid member to other fs modules as well, otherwise it will cause
> compile error.

Optional struct members are allowed (at least by gcc).  I think we have many
incomplete struct declarations throurough the code.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]