[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Environment block support for grub2

From: Robert Millan
Subject: Re: [PATCH] Environment block support for grub2
Date: Sat, 14 Jun 2008 20:32:57 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Sat, Jun 14, 2008 at 11:41:18AM +0800, Bean wrote:
> Hi,
> No problem, I can find another name.

Sorry, my mistake.  I complained about $root being inappropiate for early
stage use, but after that I noticed that $root is used in every stage to
refer to "whatever drive we're currently accessing";  even before $prefix
is initialised!

I'm fine with $root if nobody objects.

> BTW, there are now two schemes for locating device at boot, the
> environment block and robert's uuid device, which one do you favor, or
> is there other scheme you prefer ?

I think there's no problem with having two schemes as long as they don't
take extra core.img space (except for the rare use cases they're intended
to) and don't conflict with each other.

As for the "findroot" approach, I have two comments/ideas:

  - Since findroot.mod is basicaly an heuristic, and it's possible we may
    want different kinds of methods that work similarly, how about
    calling it "findroot_by_file" or something like that?  Then we could
    have a separate module for "findroot_by_uuid", etc.

  - I think your idea has the potential of obsoleting some parts of our
    init routines, maybe (if we're lucky) making kernel.img smaller.  For
    example, we currently make grub_prefix a static length string (could it
    be dynamic? -> less space); then try to extract $root from it, since we
    embedded it in the same place (if we had a scheme to specify it
    separately -> less code to parse it).

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]