grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Small fix in grub-setup


From: Javier Martín
Subject: [PATCH] Small fix in grub-setup
Date: Mon, 30 Jun 2008 03:58:34 +0200

Here goes a small fix to a grub-setup error that has driven /me crazy
for the last 4 hours: in the recent split between core_path and
core_path_dev, one occurrence of the former that should have been turned
into the latter was not, thus making grub-setup spit lots of nonsensical
(to me) "error: file not found" messages. I spent a big deal of time
trying to debug the wrong piece of code, since I stubbornly thought that
the error was in the "read-and-check" loop, while it really was later in
the file... Sigh

The fix is so simple that I post it directly here. If a ChangeLog entry
is necessary, I'd propose "complete core_path variable split" or
something along that lines.


Index: util/i386/pc/grub-setup.c
===================================================================
RCS file: /sources/grub/grub2/util/i386/pc/grub-setup.c,v
retrieving revision 1.39
diff -u -r1.39 grub-setup.c
--- util/i386/pc/grub-setup.c   26 Jun 2008 15:29:32 -0000      1.39
+++ util/i386/pc/grub-setup.c   30 Jun 2008 01:53:00 -0000
@@ -452,7 +452,7 @@
     }

   /* Now read the core image to determine where the sectors are.  */
-  file = grub_file_open (core_path);
+  file = grub_file_open (core_path_dev);
   if (! file)
     grub_util_error ("%s", grub_errmsg);


Attachment: signature.asc
Description: Esta parte del mensaje está firmada digitalmente


reply via email to

[Prev in Thread] Current Thread [Next in Thread]