[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Small fix in grub-setup

From: Pavel Roskin
Subject: Re: [PATCH] Small fix in grub-setup
Date: Mon, 30 Jun 2008 17:12:23 -0400

On Mon, 2008-06-30 at 03:58 +0200, Javier Martín wrote:
> Here goes a small fix to a grub-setup error that has driven /me crazy
> for the last 4 hours: in the recent split between core_path and
> core_path_dev, one occurrence of the former that should have been turned
> into the latter was not, thus making grub-setup spit lots of nonsensical
> (to me) "error: file not found" messages. I spent a big deal of time
> trying to debug the wrong piece of code, since I stubbornly thought that
> the error was in the "read-and-check" loop, while it really was later in
> the file... Sigh

I understand you were trying to install GRUB to a non-default root.  I'm
sorry for not testing that.

> The fix is so simple that I post it directly here. If a ChangeLog entry
> is necessary, I'd propose "complete core_path variable split" or
> something along that lines.

Actually, it's a real bug, so ChangeLog shouldn't be worded like it's
another cosmetic change like the original patch was meant to be.

I've applied your patch.  Thank you!

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]