[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] (ata.mod) Fix ATAPI protocol

From: Marco Gerards
Subject: Re: [PATCH] (ata.mod) Fix ATAPI protocol
Date: Tue, 20 Jan 2009 10:00:36 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Christian Franke <address@hidden> writes:

> Christian Franke wrote:
>> Marco Gerards wrote:
>>> Christian Franke <...> writes:
>>>> This patch fixes the data I/O protocol of the ATA PACKET command.
>>>> The current implementation does not read the byte count
>>>> registers. ATAPI read may not work if the drive sends the data in
>>>> more than one block.
>>>> In conjunction with my recent SCSI blocksize patch, ATAPI CD/DVD
>>>> drives should now work.
>>> Sorry for not commenting on many things on this list.  I am too busy
>>> to check all this.
>> N.P.
>> Meantime, I have tested the SCSI and ATAPI fixes on several PC. If there
>> are no further comments, I will commit these soon.
> Committed, plus an additional wait in grub_atapi_identify.

Great! :-)

> Open issues:
> - grub_pio_read/write() check the ERR bit without ensuring !BSY.
> - ata_read fails if (batch % size) == 0.
> - ata_write does not work at all, it uses the read cmd.

grub_ata_write does not use the read cmd, or do you mean indirectly?
In that case, where does it use the read command?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]