[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasec

From: Pavel Roskin
Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp
Date: Sun, 25 Jan 2009 23:41:49 -0500

On Fri, 2009-01-23 at 10:51 +0100, Daniel Mierswa wrote:
> Am 01/21/09 18:30, Pavel Roskin schrieb:
> > The patch looks good to me.  I would split changes to commands/search.c
> > into a separate commit.
> > 
> > Please provide ChangeLog entries for the patches.
> > 
> I will comply. Thanks for your quick response.

I'll appreciate if you write your Changelog entries according to the GNU
coding standards.  In particular, please don't abbreviate function

> 2009-01-23  Daniel Mierswa <address@hidden>
>       * commands/search.c: caseless UUID comparing

We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and
it still uses grub_strcmp().  Should it be using grub_strcasecmp() as
well?  Can we export that function to reuse it in commands/search.c?

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]