[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasec

From: Pavel Roskin
Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp
Date: Tue, 27 Jan 2009 20:49:05 -0500

On Mon, 2009-01-26 at 19:28 +0100, Daniel Mierswa wrote:
> On 26.01.2009 05:41, Pavel Roskin wrote:
> > I'll appreciate if you write your Changelog entries according to the GNU
> > coding standards.  In particular, please don't abbreviate function
> > names.
> Ok, second try.

I should have told you that I had applied your patch with rewritten
ChangeLog entries.

A quick look at your "second try" shows that you didn't check the GNU
coding standards.  You can find it using Google or another search
engine.  The part dealing with ChangeLogs is here:

> > We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and
> > it still uses grub_strcmp().  Should it be using grub_strcasecmp() as
> > well?  Can we export that function to reuse it in commands/search.c?
> Yes it should use grub_strcasecmp, thanks for noticing. I don't know
> exactly if we can reuse that function at another place. I leave that to
> someone who knows where this code is executed. :-)

The code is executed when the disk is referenced by its UUID.  OK, I'll
take care of it.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]