[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] move functionality of font_path() directly to util/grub-mkco

From: Pavel Roskin
Subject: Re: [PATCH] move functionality of font_path() directly to util/ and prefer unicode.pf2 over ascii.pf2
Date: Sat, 08 Aug 2009 01:12:15 -0400

On Fri, 2009-08-07 at 14:57 +0200, Felix Zielcke wrote:

> I commited it now with an ack from Robert on IRC.

Sorry, I'm commenting after it has been committed.  Anyway, please note
that having an approval doesn't absolve you from testing the code on
your own.  Reviews are not testing.  There was a warning introduced by
your change, and there was a syntax error after "ascii".  Also, the
formatting of the moved code should have been changed to use the same
indentation as the target file.  I have fixed all that.

Could you please explain what I should do to keep using ascii.pf2?  I
checked the script, but don't see any variable controlling that.  "make
install" would install both unicode.pf2 and ascii.pf2, so unicode.pf2
would always be preferred.

If changing the default, it's a good style to provide an easy way for
users to keep the old setting, and I just don't see it, short or
removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so
that they are never reinstalled or detected by GRUB.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]