[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] move functionality of font_path() directly to util/grub-mkco

From: Pavel Roskin
Subject: Re: [PATCH] move functionality of font_path() directly to util/ and prefer unicode.pf2 over ascii.pf2
Date: Sat, 08 Aug 2009 01:49:25 -0400

On Sat, 2009-08-08 at 07:36 +0200, Felix Zielcke wrote:

> > Could you please explain what I should do to keep using ascii.pf2?  I
> > checked the script, but don't see any variable controlling that.  "make
> > install" would install both unicode.pf2 and ascii.pf2, so unicode.pf2
> > would always be preferred.
> With the old code ascii.pf2 would be always preferred.
> There wasn't either a way to specify it.

I see. Maybe that's what we should have fixed first.

> > If changing the default, it's a good style to provide an easy way for
> > users to keep the old setting, and I just don't see it, short or
> > removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so
> > that they are never reinstalled or detected by GRUB.
> Here's now a patch which allows users to specifiy the used font with
> GRUB_FONT=ascii

First of all, I hope that the patch you will actually commit will use
sane formatting.  Diffs that ignore spacing changes are OK for review,
but not for applying as is.

I think it would be more natural to let the user specify the full path
to the file.  Setting LANG=C seems unneeded in this case.  After all,
it's the user's choice, and we cannot examine the font file to check
which characters it has.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]