[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Compiler warning in grub_cmdline_get

From: Robert Millan
Subject: Re: [PATCH] Compiler warning in grub_cmdline_get
Date: Fri, 28 Aug 2009 14:48:45 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote:
> I don't think this can actually cause a real problem, but it's a
> compiler warning since it might (e.g. if prompt ever contained "%").
>   /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: 
> In function ‘grub_cmdline_get’:
> /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c:276: 
> warning: format not a string literal and no format arguments
> 2009-08-27  Colin Watson  <address@hidden>
>       * normal/cmdline.c (grub_cmdline_get): Supply a format string as
>       the first argument to grub_printf.

Thanks Colin.  For obvious fixes like this one, feel free to commit them
right away.

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]