[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Refuse to install on XFS destroying its superblock
From: |
Vladimir 'phcoder' Serbinenko |
Subject: |
Re: [PATCH] Refuse to install on XFS destroying its superblock |
Date: |
Fri, 16 Oct 2009 22:09:41 +0200 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090701) |
Robert Millan wrote:
> On Fri, Oct 16, 2009 at 06:01:56PM +0200, Jordi Mallach wrote:
>
>> On Fri, Oct 16, 2009 at 04:03:01PM +0200, Vladimir 'phcoder' Serbinenko
>> wrote:
>>
>>> + if (memcmp (tmp_img, "XFSB", 4) == 0)
>>> + grub_util_error ("Can't install on XFS.");
>>>
>> Can this error message give some more detail on what the problem is?
>>
>
> I suggest something like:
>
> grub_util_warn ("Refusing to overwrite XFS meta-data.");
>
> This is more informative, and with grub_util_warn() user has an opportunity to
> override it if she knows what she's doing.
>
>
Installing with blocklists/to partition is considered
backward-compatibility feature. We never supported a config with XFS why
we would want bw-compat for it?
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
- [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Jordi Mallach, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock,
Vladimir 'phcoder' Serbinenko <=
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Felix Zielcke, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, address@hidden, 2009/10/17