[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Refuse to install on XFS destroying its superblock

From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH] Refuse to install on XFS destroying its superblock
Date: Sat, 17 Oct 2009 13:43:37 +0200
User-agent: Mozilla-Thunderbird (X11/20090701)

Robert Millan wrote:
> On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>>  2009-10-16  Vladimir Serbinenko  <address@hidden>
>> +    * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock.
>> +    (options): New option --destroy-xfs.
>> +    (main): Handle --destroy-xfs.
> I gave this some more thought, and I think this could be less ad-hoc.  We're
> treating XFS as if it were a "weird", unique thing just because it isn't 
> biased
> towards DOS-style boot like most filesystems are.
> Instead, I've done something more generic, using our standard filesystem
> probing engine which should be more reliable than a single memcmp.
The danger is that fs_probe may reject filesystem as valid just because
it's newer than expected.
> I propose the attached patch.
> ------------------------------------------------------------------------
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'phcoder' Serbinenko
Personal git repository: 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]