[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Testcase for checking lvm module

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Testcase for checking lvm module
Date: Fri, 09 Apr 2010 15:43:25 +0200
User-agent: Mozilla-Thunderbird (X11/20091109)

BVK Chaitanya wrote:
> Hi,
> Attached patch adds a testcase to check for GRUB's lvm module
> functionality.  It configures lvm volumes on-the-fly on temporary disk
> images, and tests to see whether grub-shell ls command identifies them
> or not.
> Since all of the LVM operations need root privilege, this real test is
> performed only when it is executed as root (or sudo make check); test
> simply passes otherwise.  In future we may add sudo-check Makefile
> target to execute these type of tests automatically sing "sudo"
> feature.
Using sudo in any of the grub scripts isn't an option. Would you like
the programs you install silently acquiring root rights? At the limited
we can make a priviliged-tests target which user will execute like:
sudo make privelegied-tests
Or we can make a script which will create
all filesystem and lvm images needing root privelgies. This will also
make repeated make check faster
But it's way better to avoid needing root privelegies in the first
place. In particular operations with images shouldn't need root
privelegies. Have you looked into fakeroot program?

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]