[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Testcase for checking lvm module

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Testcase for checking lvm module
Date: Fri, 09 Apr 2010 15:50:24 +0200
User-agent: Mozilla-Thunderbird (X11/20091109)

BVK Chaitanya wrote:
> Attached!

Plain mktemp will fail on FreeBSD. Idk for well freebsd supports linux lvm 
You don't check for real existence of these files. And letting use $PATH is 
better IMO than hardcoding path to executables
+if test `id -u` != "0"; then
+    exit 0
There should be a warning here

> ------------------------------------------------------------------------
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]