[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix Cygwin path handling

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Fix Cygwin path handling
Date: Sat, 17 Apr 2010 17:22:27 +0200
User-agent: Mozilla-Thunderbird (X11/20091109)

Christian Franke wrote:
> The Cywin path handling is broken since
> make_system_path_relative_to_its_root() functionality was moved from
> the lib script to misc.c.
> This patch should fix this. It reuses the Cygwin specific code from
> getroot.c:grub_get_prefix() which apparently is a different
> implementation of the same function.
> I would suggest to remove grub_get_prefix(), it is now only used in
> grub-emu.c and sparc64/ieee1275/grub-setup.c. Not included in the
> patch, should be done in a separate commit.
> 2010-04-14  Christian Franke<address@hidden>
>     * util/ (make_system_path_relative_to_its_root):
>     Remove broken Cygwin path conversion.
>     * util/misc.c: [__CYGWIN__] Add include and define.
>     [__CYGWIN__] (get_win32_path): Copy function from getroot.c, modify
>     for Cygwin 1.7.
Please avoid duplicating code. Rather than that rename get_win32_path to
grub_get_win32_path and remove static attribute
>     (make_system_path_relative_to_its_root): Simplify loop, replace early
>     return by break.
>     [__CYGWIN__] Add conversion to win32 path.
> ------------------------------------------------------------------------
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]